Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old comment and log line from zone_reconciler.go #3827

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Remove old comment and log line from zone_reconciler.go #3827

merged 1 commit into from
Aug 14, 2023
+0 −3

Conversation

Tea4menono
Copy link

@Tea4menono Tea4menono commented Aug 10, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove old comment and log line from zone_reconciler.go
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3819

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 10, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Tea4menono / name: Xuli Cai (bcfd99a)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Tea4menono!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Tea4menono. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2023
@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2023
@mboersma
Copy link
Contributor

mboersma commented Aug 10, 2023 •
edited
Loading

/assign @sonasingh46

(Because you implemented #1791.)

@mboersma mboersma mentioned this pull request Aug 10, 2023
Closed
1 task
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (a0dcdea) 54.86% compared to head (bcfd99a) 54.85%.
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
- Coverage   54.86%   54.85%   -0.01%     
==========================================
  Files         188      188              
  Lines       19348    19345       -3     
==========================================
- Hits        10615    10612       -3     
  Misses       8151     8151              
  Partials      582      582
Files Changed Coverage Δ
azure/services/privatedns/zone_reconciler.go 74.35% <ø> (-1.84%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jont828
Copy link
Contributor

Jont828 commented Aug 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d31625a03587ffaf1b517f38a5c11d07bab03b6

@sonasingh46
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sonasingh46

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9a19c39 into kubernetes-sigs:main Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 14, 2023
@mboersma mboersma mentioned this pull request Aug 14, 2023
Merged
4 tasks
@Tea4menono Tea4menono deleted the remove-log branch August 14, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@Jont828 Jont828

@sonasingh46 sonasingh46

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Remove old comment and log line from zone_reconciler.go
5 participants
@Tea4menono @k8s-ci-robot @mboersma @Jont828 @sonasingh46